Skip to content

EIP-7702 Integration #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 25, 2024
Merged

EIP-7702 Integration #108

merged 8 commits into from
Dec 25, 2024

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Dec 18, 2024 •
edited by pr-codex bot
Loading

Implements EIP-7702 as part of ThirdwebTransactionInput and allows wallets to IThirdwebWallet.SignAuthorization to generate it. Allows setting code to EOAs. Also added utilities to decode 1559 transactions including authorizationList.

PR-Codex overview

This PR focuses on implementing EIP-7702 authorization functionality in the Thirdweb wallet system, enhancing transaction capabilities, and adding tests for new features.

Detailed summary

  • Added run target to the Makefile.
  • Implemented SignAuthorization method in EcosystemWallet and SmartWallet.
  • Created tests for reading contracts and signing transactions.
  • Introduced Call class in Program.Types.cs.
  • Added SignAuthorization method in IThirdwebWallet interface.
  • Enhanced transaction encoding with authorization handling in ThirdwebTransaction.
  • Updated ThirdwebTransactionInput to include AuthorizationList.
  • Created EIP7702Authorization struct for authorization data.
  • Added methods for decoding transactions and authorization lists in Utils.
  • Implemented tests for signing transactions with authorization in PrivateKeyWallet.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper
EIP-7702 Integration
c63c348 
Experimenting on Odyssey for now
joaquim-verges
joaquim-verges reviewed Dec 19, 2024
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.87037% with 37 lines in your changes missing coverage. Please review.

Project coverage is 78.07%. Comparing base (b0631e7) to head (425c70d).

Files with missing lines Patch % Lines
...rdweb.Wallets/PrivateKeyWallet/PrivateKeyWallet.cs 73.17% 17 Missing and 5 partials ⚠️
Thirdweb/Thirdweb.Utils/Utils.cs 84.94% 7 Missing and 7 partials ⚠️
...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   77.96%   78.07%   +0.11%     
==========================================
  Files          28       28              
  Lines        4497     4684     +187     
  Branches      620      639      +19     
==========================================
+ Hits         3506     3657     +151     
- Misses        826      853      +27     
- Partials      165      174       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 22ffb86 into main Dec 25, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/7702 branch December 25, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges left review comments

Assignees

No one assigned

Labels

DO NOT MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xFirekeeper @codecov-commenter @joaquim-verges